Update 0064-token-data-standard.md #96
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added description of the data serialization dict and array, and added standard for attributes and traits
Added description of data serialization dict and array, and a standard has been added for attributes and traits
| snake#00 data:(SnakeData ~n) = ContentData; | ||
| chunks#01 data:ChunkedData = ContentData; | ||
| array#02 data:(HashMapE 32 ^ContentData) = ContentData | ||
| dict#03 data:(HashMapE 256 ^ContentData) = ContentData; |
Member
There was a problem hiding this comment.
I oppose the introduction of dict (or hashmap) type without listing some expected value: it leaves developer without understanding what to implement. However, since dict can be presented in any place of ContentData tree it is probably hard to make list of keys.
What about PfxHashmapE?
MrG9090
approved these changes
Dec 8, 2024
MrG9090
approved these changes
Dec 8, 2024
MrG9090
approved these changes
Dec 8, 2024
MrG9090
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added description of data serialization dict and array, and a standard has been added for attributes and traits